[Feat] Change to unix domain socket

[RandyLambert]

• Use use tokio::net::UnixListener instead of tokio::net::Unix for unix socket communication
• https://github.com/chaos-mesh/rfcs/pull/34

Signed-off-by: RandyLambert [email protected]

[Andrewmatilde]

PTAL @Hexilee

[Hexilee]

@RandyLambert Please fix the conflicts, then we can merge this PR.

[RandyLambert]

@RandyLambert Please fix the conflicts, then we can merge this PR.

@Hexilee fixed

[STRRL]

Could we merge this PR?

ping @Hexilee @Andrewmatilde

[Hexilee]

Could we merge this PR?

Yes, I think we can.

[Andrewmatilde]

I guess not , this PR will block master branch release before this PR merged. https://github.com/chaos-mesh/chaos-mesh/pull/3553

[STRRL]

I guess not , this PR will block master branch release before this PR merged. chaos-mesh/chaos-mesh#3553

hmmm, it seems this PR brings breaking changes with chaos-tproxy and it requires to merge different PRs at the same time across different repos.

And that is nearly IMPOSSIBLE.

Please consider keeping the old flags and functionality, keep both stdio and uds.

After chaos-mesh/chaos-mesh#3553 get merged, remove stdio part.

[STRRL]

I guess not , this PR will block master branch release before this PR merged. chaos-mesh/chaos-mesh#3553

hmmm, it seems this PR brings breaking changes with chaos-tproxy and it requires to merge different PRs at the same time across different repos.

And that is nearly IMPOSSIBLE.

Please consider keeping the old flags and functionality, keep both stdio and uds.

After chaos-mesh/chaos-mesh#3553 get merged, remove stdio part.

PTAL @RandyLambert , also cc @Hexilee @Andrewmatilde

[RandyLambert]

I guess not , this PR will block master branch release before this PR merged. chaos-mesh/chaos-mesh#3553

hmmm, it seems this PR brings breaking changes with chaos-tproxy and it requires to merge different PRs at the same time across different repos. And that is nearly IMPOSSIBLE. Please consider keeping the old flags and functionality, keep both stdio and uds. After chaos-mesh/chaos-mesh#3553 get merged, remove stdio part.

PTAL @RandyLambert , also cc @Hexilee @Andrewmatilde

When chaos-mesh is used, it will be based on the release versions of tdoa and tproxy. I think this pr can be merged. Before the release version of toda and tproxy pulled before the dockfile of choas-mesh is not modified, this merge will not affect the use of chaos- mesh.

[STRRL]

I guess not , this PR will block master branch release before this PR merged. chaos-mesh/chaos-mesh#3553

hmmm, it seems this PR brings breaking changes with chaos-tproxy and it requires to merge different PRs at the same time across different repos. And that is nearly IMPOSSIBLE. Please consider keeping the old flags and functionality, keep both stdio and uds. After chaos-mesh/chaos-mesh#3553 get merged, remove stdio part.

PTAL @RandyLambert , also cc @Hexilee @Andrewmatilde

When chaos-mesh is used, it will be based on the release versions of tdoa and tproxy. I think this pr can be merged. Before the release version of toda and tproxy pulled before the dockfile of choas-mesh is not modified, this merge will not affect the use of chaos- mesh.

cc @Andrewmatilde

[Andrewmatilde]

I guess not , this PR will block master branch release before this PR merged. chaos-mesh/chaos-mesh#3553

hmmm, it seems this PR brings breaking changes with chaos-tproxy and it requires to merge different PRs at the same time across different repos. And that is nearly IMPOSSIBLE. Please consider keeping the old flags and functionality, keep both stdio and uds. After chaos-mesh/chaos-mesh#3553 get merged, remove stdio part.

PTAL @RandyLambert , also cc @Hexilee @Andrewmatilde

When chaos-mesh is used, it will be based on the release versions of tdoa and tproxy. I think this pr can be merged. Before the release version of toda and tproxy pulled before the dockfile of choas-mesh is not modified, this merge will not affect the use of chaos- mesh.

But when will this PR merge?

[STRRL]

But when will this https://github.com/chaos-mesh/chaos-mesh/pull/3553 merge?

I would push the review progress about this PR and chaos-mesh/chaos-mesh#3553, are there some kind of dependencies between these PRs? eg, one PR should be merged before another PR.

[Andrewmatilde]

I would push the review progress about this PR and chaos-mesh/chaos-mesh#3553, are there some kind of dependencies between these PRs? eg, one PR should be merged before another PR.

This PR have break changes on the parts of commucation between chaos-mesh & chaos-tproxy. chaos-mesh/chaos-mesh#3553 rely on a special version of this PR. But if this PR merge we will rollback it every time when release before chaos-mesh/chaos-mesh#3553 would merged.

[STRRL]

I would push the review progress about this PR and chaos-mesh/chaos-mesh#3553, are there some kind of dependencies between these PRs? eg, one PR should be merged before another PR.

This PR have break changes on the parts of commucation between chaos-mesh & chaos-tproxy. chaos-mesh/chaos-mesh#3553 rely on a special version of this PR. But if this PR merge we will rollback it every time when release before chaos-mesh/chaos-mesh#3553 would merged.

Actually, I do not think so. As @RandyLambert said, Chaos Mesh uses a versioned release of chaos-tproxy, merging this PR into master should NOT effect anything. 🤔

[Andrewmatilde]

Actually, I do not think so. As @RandyLambert said, Chaos Mesh uses a versioned release of chaos-tproxy, merging this PR into master should NOT effect anything. 🤔

There may have a problem in chaos-tproxy. Every versioned release of chaos-tproxy now rely on the master branch of chaos-tproxy. If this PR merge in master , it will affect the PR merged after it.

[Andrewmatilde]

If this PR merged , & then I merged #44 , & then I want to use it in chaos-mesh. I need to rollback #52 ,then create a released version.