chaos-mesh
chaos-mesh copied to clipboard
chore: add service account creation as optional and allow podSecurityContext
What would you like to be added:
For helmchart, could the following fields be added?
- In
values.yaml, change theserviceAccountfield to look like this:
controllerManager:
.
.
serviceAccount:
create: true
name: chaos-controller-manager
- In
values.yaml:chaosDaemon.podSecurityContext: {}
chaosDaemon:
.
.
podSecurityPolicy: false
podSecurityContext: {}
- Then in
helm/chaos-mesh/templates/controller-manager-deployment.yaml, change the if statement to this:
{{- if .Values.controllerManager.serviceAccount.create }}
serviceAccountName: {{ .Values.controllerManager.serviceAccount.name }}
- Then in
helm/chaos-mesh/templates/controller-manager-rbac.yaml, add the following if statement around the serviceAccount:
{{- if .Values.controllerManager.serviceAccount.create }}
.
.
.
{{- end }}
Why is this needed:
- I would like to be able to not ignore the service account creation as I create it in another process and would like the ability to template the podSecurityContext for the chaosDaemon.
hi @awatterson22 , could you create a PR and help us complete it? Thanks! ❤️
hi @STRRL, thank you for your reply. I have created a PR here: https://github.com/chaos-mesh/chaos-mesh/pull/4390. Just need to add my DCO and should be all set to be reviewed. Thank you!
@STRRL, my PR is ready for review: https://github.com/chaos-mesh/chaos-mesh/pull/4390. Thank you
copy that, we would triage and review it later.