chaos-mesh icon indicating copy to clipboard operation
chaos-mesh copied to clipboard

Ability to add annotations to the ServiceAccount for Chaos Dashboard

Open dannycheung-nozomi opened this issue 3 years ago • 5 comments

helm: Ability to add annotations to the ServiceAccount for Chaos Dashboard

What problem does this PR solve?

Unable to add annotations to the ServiceAccount for Chaos Dashboard.

What's changed and how it works?

Users can specify annotations via the dashboard.serviceAccountAnnotations value.

Related changes

  • [ ] Need to update chaos-mesh/website
  • [ ] Need to update Dashboard UI
  • Need to cheery-pick to release branches
    • [ ] release-2.3
    • [ ] release-2.2
    • [ ] release-2.1

Checklist

CHANGELOG

  • [ ] I have updated the CHANGELOG.md
  • [ ] I have labeled this PR with "no-need-update-changelog"

Tests

  • [ ] Unit test
  • [ ] E2E test
  • [ ] No code
  • [ ] Manual test (add steps below)

Side effects

  • [ ] Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

dannycheung-nozomi avatar Aug 05 '22 05:08 dannycheung-nozomi

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 05 '22 05:08 ti-chi-bot

Welcome @dannycheung-nozomi!

It looks like this is your first PR to chaos-mesh/chaos-mesh 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to chaos-mesh/chaos-mesh. :smiley:

ti-chi-bot avatar Aug 05 '22 05:08 ti-chi-bot

Thanks for your contribution! I think you can fix the DCO first, thank you. https://github.com/chaos-mesh/chaos-mesh/pull/3529/checks?check_run_id=7685580851

fewdan avatar Aug 05 '22 07:08 fewdan

Hi @dannycheung-nozomi , thanks for your contribution! :tada:

I am just curious what the usage for these annotations, could you give us examples?

And please fix the DCO and append an entry in CHANGELOG.md. Thanks!

STRRL avatar Aug 07 '22 02:08 STRRL

Hi @dannycheung-nozomi , do you need any help? :)

STRRL avatar Aug 24 '22 02:08 STRRL