p5-http-tiny icon indicating copy to clipboard operation
p5-http-tiny copied to clipboard

Hook for logging request?

Open jrubinator opened this issue 6 years ago • 6 comments

I have a use case for logging some information about the request (what headers were actually sent). Does adding a hook/callback just before $handle->write_request($request); sound reasonable? If so, I can submit a patch for that.

jrubinator avatar Jun 28 '19 18:06 jrubinator

@xdg - do you have any opinion on this?

jrubinator avatar Jul 31 '19 21:07 jrubinator

Hi. I'm not actively doing Perl development on this module, so I have to abstain, as I wouldn't be responsible for reviewing or merging.

xdg avatar Aug 01 '19 14:08 xdg

Ah, is @chansen the correct person to ask now?

jrubinator avatar Aug 01 '19 14:08 jrubinator

@chansen any thoughts?

jrubinator avatar Aug 08 '19 17:08 jrubinator

This isn't a vote one way or another, but just an observation -- adding hooks would make this module less tiny. LWP::UserAgent already supports hooks, so you might find your usecase better served there.

karenetheridge avatar Sep 11 '19 15:09 karenetheridge

Another possibility could be intercepting the data written to the output handle, which would be a way to address debugging needs like #123.

xdg avatar Jul 19 '21 22:07 xdg