bezier-react icon indicating copy to clipboard operation
bezier-react copied to clipboard

[WIP, PoC] Implement polymorphic component types

Open Dogdriip opened this issue 3 years ago • 5 comments

Summary

  • [x] Polymorphic component 타입을 정의합니다.
    • PolymorphicBezierComponent
    • PolymorphicBezierComponentProps
    • PolymorphicBezierComponentRef
  • [x] Text 컴포넌트를 예시로 Polymorphic component로 변환해 봅니다.

Details

#906

WIP입니다. TS 에러 해결 및 기존 컴포넌트와의 호환성 검증 등의 추가 작업이 필요합니다.

PR 본문 작성 중입니다.

Screen Shot 2022-07-24 at 16 05 58 Screen Shot 2022-07-24 at 16 06 07 Screen Shot 2022-07-24 at 16 06 12

Browser Compatibility

OS / Engine 호환성을 반드시 확인해주세요.

Windows

  • [ ] Chrome - Blink
  • [ ] Edge - Blink
  • [ ] Firefox - Gecko (Option)

macOS

  • [ ] Chrome - Blink
  • [ ] Edge - Blink
  • [ ] Safari - WebKit
  • [ ] Firefox - Gecko (Option)

References

Dogdriip avatar Jul 24 '22 07:07 Dogdriip

⚠️ No Changeset found

Latest commit: 781e76a2a4cbed951ce97fb1888426e03d8e87e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 24 '22 07:07 changeset-bot[bot]

Chromatic Report

🚀 Congratulations! Your build was successful!

github-actions[bot] avatar Jul 25 '22 17:07 github-actions[bot]

Codecov Report

Base: 69.25% // Head: 69.25% // No change to project coverage :thumbsup:

Coverage data is based on head (781e76a) compared to base (545a18c). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1     #893   +/-   ##
========================================
  Coverage    69.25%   69.25%           
========================================
  Files          203      203           
  Lines         2859     2859           
  Branches       792      792           
========================================
  Hits          1980     1980           
  Misses         767      767           
  Partials       112      112           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 01 '22 06:08 codecov[bot]

https://github.com/kripod/react-polymorphic-types

위에 잘 구현된 다형성 타입 라이브러리가 있는데 이것을 사용하는 것은 어떨까요?

Kanary159357 avatar Mar 21 '23 10:03 Kanary159357

main 으로 베이스 변경했습니다.

sungik-choi avatar May 30 '23 05:05 sungik-choi

https://desk.channel.io/#/channels/1/team_chats/groups/1237/6642ebbe9daa35bfa2c1

channeltalk[bot] avatar May 14 '24 04:05 channeltalk[bot]