bezier-react icon indicating copy to clipboard operation
bezier-react copied to clipboard

Change `source` props type of `Icon` component

Open yangwooseong opened this issue 1 year ago • 4 comments

Self Checklist

  • [x] I wrote a PR title in English and added an appropriate label to the PR.
  • [x] I wrote the commit message in English and to follow the Conventional Commits specification.
  • [x] I added the changeset about the changes that needed to be released. (or didn't have to)
  • [x] I wrote or updated documentation related to the changes. (or didn't have to)
  • [x] I wrote or updated tests related to the changes. (or didn't have to)
  • [x] I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

  • #1313

Summary

  • bezier-icons 의 type declaration 에서 선언되는 타입을 수정하면서 Icon 컴포넌트가 받는 source 타입을 수정하지 않아 사용처에서 타입 에러가 뜹니다. 베지어에서는 타입 체크가 통과되고 있는 것은 아마 @types/[email protected] 버전에서 breaking change가 생긴 것에 의한 영향인 것 같습니다.

Details

  • Icon 의 인터페이스를 BezierIcon 을 바라보도록 수정합니다. Button types 의 LeftContent에서도 BezierIcon 을 직접 바라보고 있어서 일관성 측면에서도 이렇게 하는 게 나아보입니다.

Breaking change? (Yes/No)

  • No

References

  • https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68720/files#diff-32cfd8cb197872bcba371f5018185d2e75fa540b52cda2dd7d8ac12dcc021299L246

yangwooseong avatar Jul 09 '24 07:07 yangwooseong

🦋 Changeset detected

Latest commit: 455128bf100b5b77f90310a14418418b5d98a714

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 09 '24 07:07 changeset-bot[bot]

https://desk.channel.io/#/channels/1/team_chats/groups/1237/668ce6053cc5fed4a8f3

channeltalk[bot] avatar Jul 09 '24 07:07 channeltalk[bot]

Chromatic Report

🚀 Congratulations! Your build was successful!

github-actions[bot] avatar Jul 09 '24 07:07 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.86%. Comparing base (c3bf62a) to head (455128b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2344   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         140      140           
  Lines        2919     2919           
  Branches      879      892   +13     
=======================================
  Hits         2448     2448           
+ Misses        466      441   -25     
- Partials        5       30   +25     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 09 '24 07:07 codecov[bot]