Chan-Ho Suh

Results 31 comments of Chan-Ho Suh

Personally I find language like "on-chain query" confusing. It might be better to use language like "broadcast", because when you make the oracle "query", you are really broadcasting the request...

If you look at the raw serialized transaction, I don't think it matters whether you use the "null" address or the zero address, it serializes as the same thing so...

You can send ETH to any address, including the zero address. If a contract is created from the data payload, that ETH will be added to the contract account balance....

@jochem-brouwer Yeah, I'll concede the point. I checked several transactions that created contracts and found `0x80` there instead of an RLP-ed address. There were several stuck at the zero address...

Has anyone gone through the proposed tutorial changes to make sure everything works with all the recent updates? Or do you need a hand on that?

by the way, I noticed the truffle build artifacts are also being committed for several of the projects... is that on purpose? Not sure what benefit that provides, but possibly...

@mcardillo55 nice work here :). This is a rather nice project, but I think the most glaring thing I noticed a couple years ago when going through the code was...

I suspect there is no way to do what you want. The mock contract's (payable) `fallback` function is how it delegates to the different initialized mock functions. Your transfer ultimately...

`await erc20.mock.safeApprove.withArgs(someAddress, Zero).returns()` should be `await erc20.mock.approve.withArgs(someAddress, Zero).returns()` same is true for the other `SafeERC20` calls like `safeTransfer` etc. Think of it this way: inside your smart contract, when you...

As a funny aside, this dispatching does wreak havoc if you use `revertsWithReason` instead of `returns`, since the wrapper will intercept the revert reason and include its own "SafeERC20: low-level...