rbo icon indicating copy to clipboard operation
rbo copied to clipboard

evaluation depth goes only to min length

Open nikozoe opened this issue 2 years ago • 1 comments

In your implementation the loop only goes to

k = min(self.N_S, self.N_T, k)

However, I think it should go to the maximum. For example $S=[1,2,3,4]$ and $T=[2]$ results in $rbo = 0$ in your implementation, although there clearly is an overlap at depth 2.

nikozoe avatar Aug 07 '23 17:08 nikozoe

You would have an obvious out of range error, as you would try to access elements from the smaller lists at positions that do not exist.

jermp avatar Feb 07 '25 15:02 jermp