Unifiedtransform icon indicating copy to clipboard operation
Unifiedtransform copied to clipboard

Published 20 hours ago • verified publisher icon changeweb

refactor: clean unused imports in controllers and extend from control…

Open lavy opened this issue 2 years ago • 6 comments

Refactor for controllers:

I remove the unused imports on controllers and make Controller as the base class with SchoolSession, on this way we could get sessions from controllers

lavy avatar Jan 17 '23 03:01 lavy

@changeweb can you merge it? I want to collaborate more with the next features, we could try to implement improvements

lavy avatar Jan 17 '23 13:01 lavy

@changeweb can you merge it? I want to collaborate more with the next features, we could try to implement improvements

@lavy , Great to hear that you are eager to collaborate. I will get free time on 20th Jan and I will review these pull requests. Hope you understand.

I would appreciate if you could add tests for any PRs. Thanks for the PRs BTW.

changeweb avatar Jan 18 '23 18:01 changeweb

Hi @changeweb in the next PRs i will add tests, in this case i didn't change so much, but i want to try to help in organize first and after that introduce some tests

lavy avatar Jan 18 '23 22:01 lavy

@lavy please address the review.

changeweb avatar Jan 20 '23 19:01 changeweb

Do you review it on pair? i have no time in this moment.

lavy avatar Jan 20 '23 20:01 lavy

Do you review it on pair? i have no time in this moment.

I reviewed it. Please check now.

changeweb avatar Jan 22 '23 15:01 changeweb