Course : Add link view as student - refs BT#19231

[christianbeeznest]

[codeclimate[bot]]

An error occurred when fetching issues.

View more on Code Climate.

[ywarnier]

@christianbeeznest podrías revisar este para eliminar los conflictos con los cambios recientes de Angel ? Gracias. Lo siento por las consecuencias de no haber aprobado esto antes.

[codecov[bot]]

Codecov Report

Merging #4250 (46f298b) into master (1b78b94) will decrease coverage by 0.28%. The diff coverage is 31.73%.

:exclamation: Current head 46f298b differs from pull request most recent head f41f6d9. Consider uploading reports for the commit f41f6d9 to get more accurate results

@@             Coverage Diff              @@
##             master    #4250      +/-   ##
============================================
- Coverage     48.61%   48.33%   -0.29%     
+ Complexity     7939     7903      -36     
============================================
  Files           643      641       -2     
  Lines         25820    23997    -1823     
============================================
- Hits          12553    11598     -955     
+ Misses        13267    12399     -868     

Impacted Files	Coverage Δ
...oller/Api/AbstractFeedbackSocialPostController.php	0.00% <0.00%> (ø)
src/CoreBundle/Controller/NewsController.php	100.00% <ø> (ø)
.../CoreBundle/Controller/ResetPasswordController.php	0.00% <0.00%> (ø)
.../CoreBundle/DataFixtures/AccessUserUrlFixtures.php	0.00% <ø> (ø)
src/CoreBundle/Entity/AccessUrl.php	92.59% <ø> (-0.06%)	:arrow_down:
src/CoreBundle/Entity/AccessUrlRelCourse.php	63.63% <ø> (ø)
...c/CoreBundle/Entity/AccessUrlRelCourseCategory.php	100.00% <ø> (ø)
src/CoreBundle/Entity/AccessUrlRelSession.php	83.33% <ø> (ø)
src/CoreBundle/Entity/AccessUrlRelUser.php	55.55% <ø> (ø)
src/CoreBundle/Entity/BranchSync.php	13.70% <ø> (-0.70%)	:arrow_down:
... and 544 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ywarnier]

Este no me funciona. Descargo la rama, hago un yarn dev y veo los cambios pero no cambia nada en el comportamiento. Quizás esté faltando algo ahora (que estaba cuando hiciste el PR) que indique el ID del botón o algo, pero intenté rápido y tampoco me funcionó. Mi cambio fue añadirle id="view-as-student-link" aquí: https://github.com/chamilo/chamilo-lms/blob/master/assets/vue/views/course/Home.vue#L87

[christianbeeznest]

Genera conflictos con la version master actualizada, muchos cambios en js y modulos nuevos, pienso que este PR no deberia ser validado.

[ywarnier]

OK, lo anulo