chamilo-lms icon indicating copy to clipboard operation
chamilo-lms copied to clipboard

Published 20 hours ago • verified publisher icon chamilo

Course : Add introduction content for main course and session - refs BT#19231

Open christianbeeznest opened this issue 2 years ago • 3 comments

christianbeeznest avatar Apr 03 '22 03:04 christianbeeznest

@christianbeeznest This fixes the appearance of the edition box, but if I edit the introduction in the session course, when I return to the session-course homepage, I still see the base-course introduction (that is wrong, it should be the session-course introduction I just saved). When I refresh, it updates to the session-course introduction (which is correct).

ywarnier avatar May 18 '22 12:05 ywarnier

Hi @ywarnier , I just sent a commit with a fix, please run yarn run encore dev and clean cache (remove var/cache/*) to see the changes.

Thanks for confirmation.

christianbeeznest avatar May 18 '22 19:05 christianbeeznest

Code Climate has analyzed commit 1d09c5ae and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 5
Bug Risk 1
Clarity 1

View more on Code Climate.

codeclimate[bot] avatar May 18 '22 19:05 codeclimate[bot]

@christianbeeznest falta actualizar este y atender las observaciones de Angel (y una mía que quedó arriba)

ywarnier avatar Jan 10 '23 01:01 ywarnier

Corregido observaciones en el commit https://github.com/chamilo/chamilo-lms/pull/4234/commits/bf5ff0b8e654a6107c9a763493253bd24b1f21fc

christianbeeznest avatar Jan 11 '23 17:01 christianbeeznest

Sigo viendo conflictos para el merge, que no tengo idea de como resolver :smile:

ywarnier avatar Jan 24 '23 11:01 ywarnier

@christianbeeznest al final hacemos otro PR con esto, no? Ya se hizo o está pendiente?

ywarnier avatar Feb 01 '23 23:02 ywarnier

hola @ywarnier yo creo que creare otro PR con el master actualizado, veo que hay muchos cambios en ese archivo de esa version. Gracias.

christianbeeznest avatar Feb 01 '23 23:02 christianbeeznest