chamilo-lms icon indicating copy to clipboard operation
chamilo-lms copied to clipboard

Rename extra_field field_type and extra_field_type to item_type and data_type

Open ywarnier opened this issue 7 years ago • 2 comments

The extra_field-related tables are unnecessarily confusing because they have a "field_type" that identifies the type of value that should be stored in this extra field, and an "extra_field_type" that identifies the kind of item this extra_field relates to.

This should be clarified, renaming "field_type" to "data_type" (or "value_type") and renaming "extra_field_type" to "item_type".

Also, the term "value" in exta_field_values.value should be renamed to field_value because it is a reserved keyword in several DBMS: see https://www.petefreitag.com/tools/sql_reserved_words_checker/?word=value

ywarnier avatar Jun 07 '17 00:06 ywarnier

This is linked to #2326

ywarnier avatar Mar 09 '18 15:03 ywarnier

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 31 '20 20:07 stale[bot]

The PR is merged in master now, tested and confirmed.

christianbeeznest avatar Sep 19 '22 17:09 christianbeeznest