zag icon indicating copy to clipboard operation
zag copied to clipboard

fix: combobox empty input should not be replaced by selected value when typing

Open izznatsir opened this issue 1 year ago • 2 comments

📝 Description

On Vue and Svelte, empty input will be replaced by selected value when typing.

⛳️ Current behavior (updates)

Empty value is replaced by selected value in combobox.connect function call. Because Vue and Svelte call combobox.connect each time state is updated in derive and do not have defaultValue concept like in react, empty input value keep being replaced while typing.

🚀 New behavior

Do not replace empty value with selected value while typing.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Svelte combobox example is not yet available in this branch, but you can run the e2e-vue tests to check this fix.

izznatsir avatar Feb 17 '24 08:02 izznatsir

⚠️ No Changeset found

Latest commit: a312682ecc29d1f25812ba0dc6aa2e69a38341bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 17 '24 08:02 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-nextjs ✅ Ready (Inspect) Visit Preview Feb 18, 2024 7:54am
zag-solid ✅ Ready (Inspect) Visit Preview Feb 18, 2024 7:54am
zag-vue ✅ Ready (Inspect) Visit Preview Feb 18, 2024 7:54am
zag-website ✅ Ready (Inspect) Visit Preview Feb 18, 2024 7:54am

vercel[bot] avatar Feb 17 '24 08:02 vercel[bot]

Good catch @izznatsir

I'm merging this with #1323 to keep it in a single PR.

segunadebayo avatar Mar 25 '24 17:03 segunadebayo