panda icon indicating copy to clipboard operation
panda copied to clipboard

chore(cli): optimize updateNotifier

Open zuixinwang opened this issue 1 year ago • 1 comments

Maybe the updateNotifier should run first.

zuixinwang avatar Jun 19 '23 02:06 zuixinwang

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-docs ✅ Ready (Inspect) Visit Preview Jun 26, 2023 2:08am
panda-playground ✅ Ready (Inspect) Visit Preview Jun 26, 2023 2:08am
panda-studio ✅ Ready (Inspect) Visit Preview Jun 26, 2023 2:08am

vercel[bot] avatar Jun 19 '23 02:06 vercel[bot]

Thanks for this PR @zuixinwang,

Yes, I think the update notifier should come first before running any CLI code.

segunadebayo avatar Jun 25 '23 19:06 segunadebayo

⚠️ No Changeset found

Latest commit: e14e4fe646324d511a91f4c6347b9ba94577885d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 26 '23 02:06 changeset-bot[bot]

Aha, I move the update code to the top of the main function. 😃 Can this PR be merged? 👀 @segunadebayo

zuixinwang avatar Jun 26 '23 02:06 zuixinwang