ChakraCore icon indicating copy to clipboard operation
ChakraCore copied to clipboard

Upload `bin` directory to azure artifacts

Open ShortDevelopment opened this issue 2 months ago • 6 comments

Goals

  • Provide "nightly" builds for all platforms
  • Allow to debug per PR issues using the binaries from a CI-Run

Issues

  • macOS-builds created on CirrusCI are not included

Docs: Azure Pipeline Artifacts

ShortDevelopment avatar Apr 16 '24 21:04 ShortDevelopment

@ppenzin Could you have a quick look at this?

ShortDevelopment avatar Apr 17 '24 19:04 ShortDevelopment

@ppenzin what do you think of this temporarily storing our CI builds?

It's not clear how long they kept for.

rhuanjl avatar Apr 21 '24 18:04 rhuanjl

@rhuanjl This can be configured in the Azure DevOps settings https://learn.microsoft.com/en-us/azure/devops/pipelines/policies/retention

ShortDevelopment avatar Apr 21 '24 19:04 ShortDevelopment

@JoseIvanHernandez Please stop the spam! I've already reported you to GitHub!

ShortDevelopment avatar Apr 26 '24 12:04 ShortDevelopment

Apologies. I'm new and didn't realize it was spamming you. Certainly was not my intention. You're the first to reach out, I am very sorry.

JoseIvanHernandez avatar Apr 26 '24 12:04 JoseIvanHernandez

Apologies. I'm new and didn't realize it was spamming you. Certainly was not my intention. You're the first to reach out, I am very sorry.

When you comment on a pull request everyone tagged in it gets a notification.

I'm a little confused what you were trying to do here; a pull request (PR) is a request for the maintainers of a project to merge a contribution of some kind. This project is currently maintained by @ppenzin and I; it's up to us if/when a PR is merged.

This PR is a suggested developer experience feature from @ShortDevelopment, we're waiting until my fellow maintainer @ppenzin has a chance to consider it before deciding if to merge it.

If you have any other questions about this project (chakra core) or how to contribute to it feel free to either open an issue or join our discord server to chat (see the read me on the code page for a discord link).

rhuanjl avatar Apr 27 '24 07:04 rhuanjl

I've done a lot of small commits Just squash-merge the whole thing

ShortDevelopment avatar Apr 30 '24 17:04 ShortDevelopment