ChakraCore icon indicating copy to clipboard operation
ChakraCore copied to clipboard

Fix assertion failure in `JavascriptArray.cpp`

Open ShortDevelopment opened this issue 1 year ago • 11 comments

Fix #6770

ShortDevelopment avatar Oct 03 '22 18:10 ShortDevelopment

Please can you add a test case for this?

rhuanjl avatar Oct 03 '22 19:10 rhuanjl

Sure, but it seems like I’ve created a new assertion failure; I’ll have another look at this…

ShortDevelopment avatar Oct 03 '22 19:10 ShortDevelopment

Problem is, that the assertion error only occurred with extremely large arrays. Using the poc of the mentioned issue causes the test to timeout.

ShortDevelopment avatar Oct 03 '22 20:10 ShortDevelopment

The timeouts are on a per JS file basis - does it still timeout if this test is done in a separate file with nothing else?

rhuanjl avatar Oct 03 '22 21:10 rhuanjl

Could the test complete in 3 minutes? Normally each test file gets a 1 min timeout but tests run with the Slow tag get 3 minutes instead (and are limited to only a couple of the test builds though that's not the point here).

If even 3 minutes is too short I don't know what to do - an Assert we can't test seems pointless. @ppenzin thoughts?

rhuanjl avatar Oct 05 '22 22:10 rhuanjl

I agree, we should try to run it as a separate test and mark as slow (given it does finish in 3 minutes).

ppenzin avatar Oct 06 '22 06:10 ppenzin