ChakraCore
ChakraCore copied to clipboard
Bump minimist from 1.2.5 to 1.2.6 in /test/WasmSpec/convert-test-suite
Bumps minimist from 1.2.5 to 1.2.6.
Commits
7efb22a1.2.6ef88b93security notice for additional prototype pollution issuec2b9819isConstructorOrProto adapted from PRbc8eceetest from prototype pollution PR- See full diff in compare view
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the Security Alerts page.
(Edit) re-ran the pipeline, errors in MSVC builds look like this:
Trying to locate Dev16...
Dev16 not found, trying to locate Dev15...
Dev15 not found, trying to locate Dev14...
Dev14 not found, trying to locate Dev12...
Dev14 not found, trying Dev 12.0
Can't find msbuild.exe in "C:\Program Files (x86)\msbuild\12.0\Bin\amd64"
This looks like Visual Studio versions it is trying. Will check later.
This can be due to handling of msbuild path in Build/scripts/add_msbuild_path.cmd, investigating.
Temporarily moved CI to use windows-2019 image, will investigate further.
@dependabot rebase
Now we need #6830 to get past the agreement check and that should be it for this update.
/cc @rhuanjl
Now with dependabot out of the agreement check. @dependabot rebase
@rhuanjl this is another PR that I'm going to close without a second reviewer, two more are #6830 and #6829. All of those have been really minor, though I'd rather not do that for very long.