ChakraCore icon indicating copy to clipboard operation
ChakraCore copied to clipboard

Bump minimist from 1.2.5 to 1.2.6 in /test/WasmSpec/convert-test-suite

Open dependabot[bot] opened this issue 3 years ago • 1 comments

Bumps minimist from 1.2.5 to 1.2.6.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

dependabot[bot] avatar Apr 10 '22 01:04 dependabot[bot]

(Edit) re-ran the pipeline, errors in MSVC builds look like this:

Trying to locate Dev16...
Dev16 not found, trying to locate Dev15...
Dev15 not found, trying to locate Dev14...
Dev14 not found, trying to locate Dev12...
Dev14 not found, trying Dev 12.0
Can't find msbuild.exe in "C:\Program Files (x86)\msbuild\12.0\Bin\amd64"

This looks like Visual Studio versions it is trying. Will check later.

ppenzin avatar May 18 '22 06:05 ppenzin

This can be due to handling of msbuild path in Build/scripts/add_msbuild_path.cmd, investigating.

ppenzin avatar Aug 11 '22 19:08 ppenzin

Temporarily moved CI to use windows-2019 image, will investigate further.

@dependabot rebase

ppenzin avatar Aug 12 '22 18:08 ppenzin

Now we need #6830 to get past the agreement check and that should be it for this update.

/cc @rhuanjl

ppenzin avatar Aug 13 '22 06:08 ppenzin

Now with dependabot out of the agreement check. @dependabot rebase

ppenzin avatar Aug 16 '22 23:08 ppenzin

@rhuanjl this is another PR that I'm going to close without a second reviewer, two more are #6830 and #6829. All of those have been really minor, though I'd rather not do that for very long.

ppenzin avatar Aug 17 '22 00:08 ppenzin