Prem Chaitanya Prathi
Prem Chaitanya Prathi
Wow, this is surprising that load balancing across multiple listeners is not functioning on windows as well as Mac even-though 2 sockets are allowed to listen on same address+port. Wrt...
Update on further investigation, looks like macOS also doesn't support load balancing across listeners. Few refs: [Ref1](https://stackoverflow.com/questions/41247790/so-reuseport-on-macos-with-libuv) [Ref2](https://github.com/uNetworking/uWebSockets/issues/1194) So, for now I have skipped checking for load balancing of connections...
Pushed changes to reuse port in case of dailing. Note that in case of wss with SNI, reuse port cannot be used as the dail function has already been replaced...
@marten-seemann @MarcoPolo All required changes and review comments have been addressed. Please go ahead and merge this PR if nothing else is required.
Surprisingly the test is successful now, i ran it on a local ubuntu vm (Ubuntu 22.04.3 LTS) as well and there also tests are successful. It is hard to determine...
> I reran the test suite and it's failing again. We can't introduce any flaky tests, please make sure it consistently passes (you can run the test suite with `-count=1000`...
> @chaitanyaprem just checking in. Let me know if you have any questions here. I'm available in filecoin slack(link in repo README). Got little busy with other work and hence...
> Thanks @Maelkum. This PR has been dormant for a while so I think it's okay. Do you want to open a new PR or take over this one? @chaitanyaprem...
Ok, but shouldn't it be the default option. I am wondering as to why would a node want to publish if there are no peers to publish. Is there some...
The log looks similar to what we have seen during a unit test failure as reported in #658 . Are you seeing any functional issue due to this? Never thought...