trRouting icon indicating copy to clipboard operation
trRouting copied to clipboard

Should not allow a route with the same departure and arrival nodes

Open kaligrafy opened this issue 4 years ago • 4 comments

It happens on some networks with sparse lines and paths

kaligrafy avatar Feb 08 '21 19:02 kaligrafy

@kaligrafy Thinking of a few details here: Do we want to skip if there's exactly just one departure and arrival node and they are the same ? If there's multiple, do they need to be exactly the same set? Or if they have one node in common, we also skip it? What should be the error message? (See the API doc.)

greenscientist avatar Nov 25 '23 16:11 greenscientist

We should return an error message if only one origin and arrival nodes and they are the same. Like "Origin and destination nodes are the same"

kaligrafy avatar Nov 27 '23 13:11 kaligrafy

For the case with multiple orign and destianation nodes, I don't know, transit routing could still be possible, but highly unlikey to be used, except with very large maximum access/egress walking travel times.

kaligrafy avatar Nov 27 '23 13:11 kaligrafy

We should return an error message if only one origin and arrival nodes and they are the same. Like "Origin and destination nodes are the same"

Ok, should be easy to add the check for this case.

greenscientist avatar Nov 27 '23 16:11 greenscientist