chainloop icon indicating copy to clipboard operation
chainloop copied to clipboard

standardize Helm Chart with Bitnami Practices

Open migmartri opened this issue 1 year ago • 1 comments

From https://github.com/bitnami/charts/pull/27100#issuecomment-2256043379

NOTE: It's essential to evaluate and discuss each breaking change we might add to the chart.

### Tasks
- [x] Openshift settings
- [x] hardcoded ports in configmap/secrets
- [x] auto-scaling
- [x] network policies
- [ ] tls.existingSecret? https://github.com/bitnami/charts/pull/27100#discussion_r1705381329
- [x] fix hpa i.e  averageUtilization: {{ .Values.controlplane.autoscaling.hpa.targetMemory }}
- [x] hardcode container names "We usually hardcode a container name, in this case we could use 'controlplane'"

migmartri avatar Jul 29 '24 14:07 migmartri

So the chart has now been merged in Bitnami. Awesome! Great work @javirln!

I believe the last batch of feedback included some missing features in our chart that were applied in their branch, but not in ours. I think some of those changes should be merged also in our chart. @javirln do you have any suggestion on which ones should we add back?

migmartri avatar Aug 12 '24 07:08 migmartri