melange icon indicating copy to clipboard operation
melange copied to clipboard

Add build-gpep517 pipeline for Python

Open Dentrax opened this issue 1 year ago • 4 comments

This PR adds a new Python pipeline called: python/build-gpep517.

In case if upstream project does not provide neither pyproject.toml or setup.py, so python/build and python/build-wheel pipelines does not work as expected since both pipelines uses build module and depends on aforementioned files to run correctly. Invoking the python-build with -m gpep517 rather than -m build, resolves this issue.

Dentrax avatar Sep 06 '23 20:09 Dentrax

Why not just use gpep517 directly in python/build? As far as I can tell gpep517 does handle legacy setup.py scripts?

kaniini avatar Sep 07 '23 20:09 kaniini

As far as I can tell gpep517 does handle legacy setup.py scripts?

Hmmm, how can we be sure that it won't break the existing as-is flow? I was thinking to invoke gpep517 module if there isn't any setup.py.

Dentrax avatar Sep 11 '23 19:09 Dentrax

Any thoughts? @kaniini

Does it make sense to check pyproject.toml and setup.py files whether exist, if so use as-is, otherwise fallback to gpep517 way?

Dentrax avatar Sep 18 '23 18:09 Dentrax

How should we proceed here?

cc @imjasonh

Dentrax avatar Oct 19 '23 09:10 Dentrax