melange icon indicating copy to clipboard operation
melange copied to clipboard

RFE: fix absolute symlinks to relative

Open smoser opened this issue 1 year ago • 2 comments

Generally, absolute symlinks are less "nice" than relative, as they assume the reader is rooted at /. In an installed system that is going to be true, but if you extract a package or container it is not true.

I would like to do this by default, and enable it to be turned off, but I don't have an actual example of why we'd want to turn it off.

smoser avatar Aug 16 '24 15:08 smoser

related https://github.com/chainguard-dev/melange/issues/1435

smoser avatar Aug 16 '24 15:08 smoser

There is code in tw in usrmerge-tool (https://github.com/chainguard-dev/tw/tree/cb0b344a44d5a6757e35b7d8e7d67e1a69493b74/usrmerge-tool) that can turn absolute symlinks into clean relative symlinks. It would be best to expose that as a pipeline that only does absolute to relative, as we do not need usrmerge cleanup any more. The code has never been used in production.

That could be used on each subpackage, or paired with 'finalize' pipelines https://github.com/chainguard-dev/melange/pull/1785, or pulled into melange proper

smoser avatar Aug 28 '25 13:08 smoser