chainercv icon indicating copy to clipboard operation
chainercv copied to clipboard

Set names of output Variables from PickableSequentialChain

Open ktns opened this issue 5 years ago • 3 comments

Set names of output Variables from PickableSequentialChain, so that they match with names in pick and layer_names.

This is for more readable computational graphs.

ktns avatar Feb 25 '19 04:02 ktns

There is a possibility that a user of PickableSequentialChain uses a function that outputs a variable with name...

yuyu2172 avatar Feb 25 '19 07:02 yuyu2172

How about setting the name only when var.name is None?

yuyu2172 avatar Feb 26 '19 04:02 yuyu2172

If an instance of PicakbleSequentialChain has a nested PickableSequentialChain as its child, I think its better var.name is rewritten by the parent because the parent tends to have more information about the whole structure of the NN. I thought a scheme like parent_name/child_name is too complicated, but it might require reconsideration.

ktns avatar Mar 03 '19 07:03 ktns