chainer-chemistry icon indicating copy to clipboard operation
chainer-chemistry copied to clipboard

Weight tying option has a bug

Open knshnb opened this issue 5 years ago • 1 comments

If weight_tying option is True, only one update layer is called regardless of n_update_layers

https://github.com/pfnet-research/chainer-chemistry/blob/master/chainer_chemistry/models/gin.py#L37

knshnb avatar Sep 20 '19 04:09 knshnb

So we should change this line to self.n_update_layers ? https://github.com/pfnet-research/chainer-chemistry/blob/master/chainer_chemistry/models/gin.py#L92

corochann avatar Sep 20 '19 05:09 corochann