chainer-chemistry icon indicating copy to clipboard operation
chainer-chemistry copied to clipboard

train_valid_split sometime fails.

Open corochann opened this issue 5 years ago • 0 comments

BaseSplitter's train_valid_split checks assert len(test_inds) == 0.

when i use RandomSplitter, it failed. i guess calculation of

        train_data_size = int(len(dataset) * frac_train)
        valid_data_size = int(len(dataset) * frac_valid)

may sometimes remain rest indices even if frac_train + frac_valid == 1.

we should check other splitter class and add test too.

corochann avatar Feb 04 '19 02:02 corochann