keplr-wallet icon indicating copy to clipboard operation
keplr-wallet copied to clipboard

feat: support for injective as beta

Open bangjelkoski opened this issue 2 years ago • 6 comments

We had a couple of discussions on Telegram regarding supporting Injective as per recent development by the Evmos team to support signing for coinType = 60 so we've made a branch that does that. There is also an addition to parse injectiveAddress to Ethereum address as per Evmos's example.

And, this is the config:

export const INJECTIVE_RPC_ENDPOINT = "https://tm.injective.network";
export const INJECTIVE_RPC_CONFIG: AxiosRequestConfig | undefined = undefined;
export const INJECTIVE_REST_ENDPOINT = "https://lcd.injective.network";
export const INJECTIVE_REST_CONFIG: AxiosRequestConfig | undefined = undefined;

bangjelkoski avatar Mar 07 '22 19:03 bangjelkoski

EVMOS support is not maintained by our team. Current EVMOS implementation not only based on coinType=60, but also based on bech32 prefix, referencing and supporting in somewhat hard-coded way. Therefore, even though using coinType=60 may function, it does not guarantee further functioning in future PRs of EVMOS. Keplr team does not currently use internal resources to support EVMOS. However, I am willing to merge this PR when the Ethermint team has implemented considering the case of Injective

Thunnini avatar Apr 13 '22 11:04 Thunnini

Hey @Thunnini I've just updated the PR to add support for Keplr users to be able to sign transactions on Injective directly on Keplr.

bangjelkoski avatar Jun 30 '22 17:06 bangjelkoski

Hey @Thunnini can this get merged now?

albertchon avatar Jul 28 '22 01:07 albertchon

Hey @Thunnini this PR is good to go now. Could you merge it?

albertchon avatar Aug 05 '22 00:08 albertchon

No, please remove the injective from chain infos. We don't add the chain natively by PR. And, consider the other way to remove if (chainId === "foo" || chainId === "bar") part. Alternatively, use features field in ChainInfo

Thunnini avatar Aug 10 '22 11:08 Thunnini

Just updated the PR @Thunnini

bangjelkoski avatar Aug 10 '22 11:08 bangjelkoski

Ping @Thunnini

bangjelkoski avatar Aug 16 '22 01:08 bangjelkoski

Bump @Thunnini - can this get merged now?

albertchon avatar Aug 17 '22 16:08 albertchon