chai icon indicating copy to clipboard operation
chai copied to clipboard

is it possible to bump deep-eql to ^4.0.0 in chai 4.x.x

Open Ucandoit opened this issue 2 years ago • 4 comments

Hi, now that this PR is merged in deep-eql https://github.com/chaijs/deep-eql/pull/88, I'd like to make a new release of chai so that we can fix the bug of comparison in Temporal objects. I figured out that in chai 4.x.x, the deep-eql version is set to ^3.0.1. Do you have any idea why it stays in v3 and whether I can bump its version to ^4.0.0? It seems that all tests pass when I bump to 4.1.0 in local environment

Ucandoit avatar Jul 11 '22 14:07 Ucandoit

Chai v4 cannot use v4 of deep-eql because it includes breaking changes around error comparison (https://github.com/chaijs/deep-eql/releases/tag/v4.0.0).

It may be worth making a Chai v5 release which upgrades these, while also dropping support for old versions of Node & IE to allow us to make more changes to support newer features.

keithamus avatar Jul 11 '22 15:07 keithamus

OK I see. What's the status of v5? Is it releasable or there are stuffs to finish before releasing?

Ucandoit avatar Jul 12 '22 07:07 Ucandoit

We had plans to make some more sweeping changes in v5 but it might be too much in one go. So I think we should just cut a v5 which drops support for old engines and lets us do the bigger changes in v6

keithamus avatar Jul 12 '22 08:07 keithamus

@Ucandoit what do you think we should do here now that chai v5 is out?

koddsson avatar Jan 24 '24 21:01 koddsson