chai icon indicating copy to clipboard operation
chai copied to clipboard

`.above` and `.least` aliases not consistent

Open IanKemp opened this issue 5 years ago • 3 comments

The documentation for .above states:

The aliases .gt and .greaterThan can be used interchangeably with .above.

However, for .least:

The alias .gte can be used interchangeably with .least.

To my mind, there should be a .greaterThanOrEqual alias for .least in addition to the current .gte alias, for conformity in the use of these APIs.

The same applies to .below and .most; the latter would benefit from a .lessThanOrEqual alias.

IanKemp avatar Jan 16 '20 09:01 IanKemp

I'm a first-timer here, and I was looking for a way to contribute. Can I tackle this one @keithamus?

Neob91 avatar Feb 02 '20 15:02 Neob91

Absolutely @Neob91! Always happy to have new contributors. Let us know if you need any more info to proceed!

keithamus avatar Feb 02 '20 15:02 keithamus

Thanks for making me feel welcome @keithamus! I opened a pull request (#1319) - please let me know if I missed anything.

Neob91 avatar Feb 03 '20 09:02 Neob91