chai
chai copied to clipboard
`.above` and `.least` aliases not consistent
The documentation for .above states:
The aliases
.gtand.greaterThancan be used interchangeably with.above.
However, for .least:
The alias
.gtecan be used interchangeably with.least.
To my mind, there should be a .greaterThanOrEqual alias for .least in addition to the current .gte alias, for conformity in the use of these APIs.
The same applies to .below and .most; the latter would benefit from a .lessThanOrEqual alias.
I'm a first-timer here, and I was looking for a way to contribute. Can I tackle this one @keithamus?
Absolutely @Neob91! Always happy to have new contributors. Let us know if you need any more info to proceed!
Thanks for making me feel welcome @keithamus! I opened a pull request (#1319) - please let me know if I missed anything.