Chad Remesch

Results 27 comments of Chad Remesch

@arrbee thanks for tracking it down! Jut to confirm your code works for me. One additional note... I have to run `RAILS_ENV=test rake teaspoon` for this to work. Or else...

@movitto great analysis of the problem and also for coming up with a simple demo. Nesting timers wasn't something I needed or designed for. Time for this project is very...

This issue is most likely solved in PR #10 (leaving a note here in case anyone else runs into it).

@movitto I started review your code and I am thinking about a potential different solution. I need to dig in deeper, but upon first looking at it, it may be...

@lightalloy I believed mentioned this problem to me too. So definitely sounds like it’s going to be a major problem. Hopefully it’s possible to have a second parser to resolve...

@lightalloy I hope your colleagues agree to it! PRs welcome!

I've updated all the test data by running ```./bin/update_test_data``` and pushed the commit to master. This results in most of the tests now failing. If anyone works on new scrapers...

@refaelos submitted PR #74 that may fix the scrapers, but decreases code coverage. Is anyone else working on fixing the scrapers? If so, it would be helpful to coordinate here....

@lightalloy thanks!!! I agree the code is a good start and needs further refactoring and has some missing attributes. Do you feel it is good enough to merge into master,...

@refaelos Thank you for the fast response. A few questions: - Are all of those 'ifs' already in the PR? or do you have new ones? - Are you planning...