react-bs-notifier
react-bs-notifier copied to clipboard
Close button style is broken with Bootstrap 5.
Hi,
As a breaking change in Bootstrap 5. The 'x' will not be rendered as button and displayed at the wrong side.
https://getbootstrap.com/docs/5.0/migration/#close-button
Cheers,
Vincent
I don't really use this library anymore and don't have the energy to put development time into it.
I'm happy to merge a PR to fix issues like this though, if you are willing to fix it.
The change is relatively simple, but would break compatibility with earlier versions of Bootstrap.
@chadly do you have a preferred mechanism for supporting both Bootstrap flavours? Different component names? Different import paths? New major version on NPM (with the idea of maintaining both major versions). New npm package react-bs5-notifier built from the same repo, or a fork?
definitely not going to manage multiple versions. but I think doing a major version upgrade with support for newer bootstrap versions makes sense going forward.
in other words, forget about backwards compatibility 😁