Christian Adell

Results 133 comments of Christian Adell

Adding @gsnider2195 as the original code contributor

> https://github.com/nautobot/nautobot/blob/develop/nautobot/extras/jobs.py#L1243 I agree on the idea. I would cover the `object_repr` too. I believe that the truncation is the most conservative approach, as it will cover our backs whatever...

We could move to 400 (to account for the application name). But, I will also apply truncation to solve this once and for all.

I understand your point on facilitating the integration with the delivery pipeline, but I also see using two tools is something good because if not we are making it too...

> There is a fork @einarnn do you think it would be contributed upstream?

I understand that we can make uniqueness options more restrictive with custom validators, but not the other way around. How can I overwrite the unique together definition in the DB?

> Related? #3111 #4171 Yes, I think that `controllers` is a good implementation

Yes, I think that #1957 solves it (even before I created the issue). @minitriga do you agree?

This could be a good opportunity to create an ADR record, to explain the overall approach.