node-hashtable icon indicating copy to clipboard operation
node-hashtable copied to clipboard

Published 20 hours ago • verified publisher icon chad3814

Build fails on macOS Sierra

Open crazyquark opened this issue 8 years ago • 5 comments

The build fails on macOS Sierra because it tries to include <tr1/unordered_map>. This was on version 2.0.2.

crazyquark avatar Feb 01 '17 08:02 crazyquark

I've created a PR that fixes this: https://github.com/chad3814/node-hashtable/pull/33

crazyquark avatar Feb 01 '17 23:02 crazyquark

Can you tell me how to fix the issue in detail, because i don't quiet understand what is PR and how it works,thanks a lot for your kindness !

leyeye avatar Apr 05 '17 07:04 leyeye

As of macOS 10.12 Sierra, the default is now libc++ and libstdc++ is deprecated. libstdc++ is quite old, v4.2.1, and predates C++11 (hence the tr1 headers). If you're going to be using this code long-term, it'd be worth the time to at least make it C++11 compliant (i.e. #include <unordered_map>)

sharper avatar Jun 08 '17 01:06 sharper

This module can't be build on MacOS X (10.11.6) when using v8 (works fine with v6 though). We have some dependencies on hashtable so I'm hoping the package maintainer will create a new build soon...

peterkuiper avatar Jun 09 '17 09:06 peterkuiper

Any update on merging and releasing this? I could use it too. It won't build on macOS.

timothystewart6 avatar Sep 13 '18 01:09 timothystewart6