generator-cg-angular icon indicating copy to clipboard operation
generator-cg-angular copied to clipboard

upgrading to angularjs 1.3.x

Open marcdexet-cnrs opened this issue 9 years ago • 8 comments

Hi, Is an upgrade is planned to use ng 1.3.x ?

Tx

marcdexet-cnrs avatar Dec 05 '14 23:12 marcdexet-cnrs

Yes. Sometime soon.

cgross avatar Dec 06 '14 22:12 cgross

+1 What is the hold up? What is necessary beyond updating bower.json? I'd be willing to put in some hours for this to happen.

joeljeske avatar Jan 09 '15 20:01 joeljeske

The problem is the dependency for angular-bootstrap.This lib supports only 1.2.x yet.

AnBauer avatar Feb 09 '15 14:02 AnBauer

depending on what parts of uibootstrap you need it's "safe" to upgrade to 1.3.x. Some stuff like datepicker have quickfixes, others kinda borked, so ymmv.

ragefuljoe avatar Apr 07 '15 14:04 ragefuljoe

angular-bootstrap.0.13.0 added support of angular 1.3

Is there are any problems with pull request from @adnasa?

terales avatar May 09 '15 08:05 terales

The problem is the dependency for angular-bootstrap.This lib supports only 1.2.x yet.

Do you have resource supporting this statement? 0.13.0 has been out for a little while now and even the site mentioned the following:

AngularJS (requires AngularJS 1.3.x, tested with 1.3.13). 0.12.0 is the last version of this library that supports AngularJS 1.2.x.

I don't see any reason for waiting any longer

@terales Is PR #71 relevant/up to date to follow up on this issue? of course, I can spend some amend my PR if needed ;)

Take care!

adnasa avatar May 09 '15 18:05 adnasa

@adnasa, I've already used your PR as template to update my app dependencies. But I can't merge it to main generator repository, so I stated a question to maintainers.

I think they can merge it without any problems and with value for all who starts new app now.

terales avatar May 10 '15 12:05 terales

okay. then we'll wait for @cgross after he's finished consulting his crystal ball of enlightenment :grinning:

adnasa avatar May 10 '15 21:05 adnasa