angular-prompt

angular-prompt copied to clipboard

If in angular 1.3 you disable debug info like so: ``` $compileProvider.debugInfoEnabled(false); ``` Then this breaks this plugin when submitting a prompt with a modal. This PR fixes tie behaviour.

mattlewis92

'x' in modal close renders as strange capital A and hyphen

1

replace `x` with `×` here https://github.com/cgross/angular-prompt/blob/6de8bdfdaa8862488f6deb53c5e5233ac6e77129/dist/angular-prompt.js#L109 Note: this is what bootstrap does http://getbootstrap.com/javascript/#static-example I can submit a pull request for the small change.

phil-dileo

If option 'input' was set to false, there were no focused element. This pull request adds focus on primary button (if exist and input==false).

zagorski

Removed hard coded interpolation

1

If not using default interpolation, template will not work. Added start and end symbols as variables from interpolate service provider.

AndreasLoukakis

Hard coded start & end symbols can cause rendering issues

2

I use different start and end symbols in my angular app: ``` config(function($interpolateProvider){ $interpolateProvider.startSymbol('{[{').endSymbol('}]}'); }) ``` Unfortunately, that isn't honored by angular-prompt. It would be helpful to have the start...

toddrun

Stupid question - Submitting pull request?

1

Hi sorry for the stupid question, would like to submit a pull request. How can I set everything up locally and compile a new version? Are there any tests I...

hendricius