clashroyale icon indicating copy to clipboard operation
clashroyale copied to clipboard

Published 20 hours ago • verified publisher icon cgrok

OfficialAPI: add river race and river race log endpoints

Open gogaz opened this issue 5 years ago • 6 comments

Changes Description

Update war logs URL to match the latest version of Clash Royale Given that the endpoint data format for river races slightly differs from previous clan wars, I advocate for new methods over modificating get_clan_war* methods.

Type of PR

  • [ ] Bug Fix
  • [x] Feature Addition

Checklist

  • [x] Docstrings added (NumpyDoc)
  • [ ] If necessary, add to the documentation files
  • [X] Add to the CHANGELOG file
  • [X] Tox checked

gogaz avatar Sep 16 '20 11:09 gogaz

@fourjr any chance to have this reviewed any time soon?

gogaz avatar Sep 19 '20 12:09 gogaz

How is this going @fourjr ? I'm interested in using it in my project.

igonro avatar Oct 01 '20 15:10 igonro

Hey, I've been busy over the past week. Will review and push to PyPi by end of next week.

fourjr avatar Oct 04 '20 04:10 fourjr

Hey, sorry for the late reply, why isn't the get_clan_war method removed? From the api documentation, /currentwar is no longer in use. image

fourjr avatar Oct 17 '20 12:10 fourjr

@fourjr good catch, I hadn't tested it! What do you think we should do with get_clan_warlog? It's been showing possibilities to bring it back are being investigated for almost 3 monthes now so it sounds like it's not going to be back again...

gogaz avatar Nov 01 '20 12:11 gogaz

What status with this branch?

PaKostya avatar Oct 31 '21 19:10 PaKostya