cgrindel
fix: windows issues
There are multiple issues on windows:
- https://github.com/bazelbuild/bazel-skylib/pull/527
- https://github.com/cgrindel/bazel-starlib/issues/448
- https://github.com/cgrindel/bazel-starlib/issues/449
- https://github.com/cgrindel/bazel-starlib/issues/447
- https://github.com/cgrindel/bazel-starlib/issues/450
Issues 2-5 above are all fixed by this PR
Test results (windows)
(still filling in these results) Before --enable_runfiles 332 failures --noenable_run
With buildifier_prebuilt update only --enable_runfiles 116 failures --noenable_run 154 failures + skips
With this PR only --enable_runfiles 34 failures --noenable_runfiles 122 failures + skips
With this PR and https://github.com/bazelbuild/bazel-skylib/pull/527 --enable_runfiles 0 failures --noenable_runfiles 85 failures
Future activity
Note: most of the --noenable_runfiles failures are of this form. It seems that bzlformat_lint_test.sh is designed to require runfiles.
INFO: From Testing //tests/shlib_tests/lib_tests/files_tests:bzlformat_lint_test:
==================== Test output for //tests/shlib_tests/lib_tests/files_tests:bzlformat_lint_test:
D:/udu/b/356umzpb/execroot/_main/bazel-out/x64_windows-fastbuild/bin/tests/shlib_tests/lib_tests/files_tests/bzlformat_lint_test.sh: line 14: tests/shlib_tests/lib_tests/files_tests/bzlformat_lint_test_BUILD.bazel.sh: No such file or directory
tests/shlib_tests/lib_tests/files_tests/bzlformat_lint_test_BUILD.bazel.sh failed with 127.
1 lint tests failed.
================================================================================
Look into this:
INFO: From Action tests/bzlrelease_tests/rules_tests/generate_workspace_snippet_tests/archive_sha256:
which: no shasum in (/usr/bin:/usr/bin:/bin:/c/WINDOWS:/c/WINDOWS/System32:/c/WINDOWS/System32/WindowsPowerShell/v1.0)
@cgrindel thanks for your review. It looks like a bunch of CI checks failed with an API key error, could you help with that?