cppfs

cppfs copied to clipboard

- Merge FilePath, move in & adapt test - Merge fs.h & fs.cpp - Move in directorytraversal

scheibel

https://github.com/cginternals/cppfs/blob/ae2062b5558b5ffc35e44d2538f73145aa266fd6/source/cppfs/source/windows/LocalFileHandle.cpp#L201-L204

xahon

Remove sha1 and base64 functions

1

Having sha1 requires dependency on OpenSSL when it is not necessary. A filesystem library should ONLY provide the basic functionality to traverse folders, and provide means to read/write to file...

robiwano

Obtain CWD/PWD

1

Hey! I was looking through the source files and could, thus far, not find out if cppfs supported obtaining the current working directory. Unfortunately, there are a lot of information...

IngwiePhoenix

Remove std templates from interface

2

I would remove std::string (and other templates) from the interface and would replace it with const char* when returning for example the file name, etc. I believe this might be...

lppinto

I just wonder why? What's the reason? https://github.com/cginternals/cppfs/blob/e6b03ac2f4d919497acec121dc4df0b69c591257/CMakeLists.txt#L87-L89

xahon

FileHandle.size() does not work well for large file(more than 3.9GB)

2

`FileHandle.size()` use `unsigned int` to return the size of the file, which only has `4,294,967,295`. Not enough for larger file.

Gabirel

Handling unicode paths

1

As far as I can see, it is not possible to use paths on Windows such as `C:\Överkörd\Überförare\`, maybe paths should be considered UTF-8, then convert to wchar_t* for use...

robiwano

https://github.com/cginternals/cppfs/blob/e6b03ac2f4d919497acec121dc4df0b69c591257/source/cppfs/include/cppfs/cppfs.h#L16 3 definitions in that file. I'm sure that there are another usages of `enum` in the project

xahon

If you have two file Tree and call `auto diff = tree0.createDiff(tree1);` if `tree0` has a folder called `foo` and `tree1` has had that folder removed and a file added...

AtomicNibble