cmake-init icon indicating copy to clipboard operation
cmake-init copied to clipboard

Drop GenerateExportHeader and WriteCompilerDetectionHeader

Open Tachi107 opened this issue 2 years ago • 2 comments

GenerateExportHeader doesn't do anything special that can't already be known before building the project (i.e. a regular, static header file has no disadvantages over it), and it creates issues in MultiArch environments, as the generated export header is compiler dependant (related to #35). See https://github.com/zyantific/zycore-c/pull/41 for an example.

WriteCompilerDetectionHeader already generates issues in cmake-init, as it isn't available in CMake versions older than 3.2; at the same time, the module got removed in CMake 3.20.

Tachi107 avatar Oct 05 '22 20:10 Tachi107

Thanks for the suggestion. I'm glad C++ and CMake evolved to get rid of those headers and I'm planning to remove the need for them. Maybe we can get rid of pre-compiled feature headers altogether.

scheibel avatar Feb 05 '23 21:02 scheibel

Just for cross-reference: we encountered this issue before: https://github.com/cginternals/glbinding/issues/333

scheibel avatar Feb 11 '23 17:02 scheibel