Downsize icon indicating copy to clipboard operation
Downsize copied to clipboard

Published 20 hours ago • verified publisher icon cgiffard

removing xregexp

Open mansona opened this issue 7 years ago • 1 comments

Hi there 👋

I needed to remove the xregexp dependency because I am running downsize in the browser, this is an entirely nieve implementation but it seems to work reasonably well 🎉

There are 2 tests failing, stuff to do with unicode which is why I assume you were using XRegExp 😂

I'm opening this PR to start the discussion, let me know if you have any thoughts 👍

mansona avatar Jan 09 '18 18:01 mansona

Hi there 👋 I got this working in the end relying on the default unicode support the JS platform. Essentially it amounts to a situation where it will support unicode if your environment supports http://node.green/#ES2018-features--RegExp-Unicode-Property-Escapes

I have also skipped 2 tests that have been broken because of my simplification of the overall system and the removal of XRegexp.

Let me know if you have any questions.

mansona avatar Mar 11 '18 17:03 mansona