Don't send analytics data without permission

[nmushegian]

The gas reporter is hitting the coinmarketcap API without asking or telling

[cgewecke]

This isn't sending analytics data. It's requesting price data.

[nmushegian]

There is a lot of metadata in the request Coinmarketcap is not exactly a “no logs” company I’m not suggesting you are collecting analytics data, but someone is

[cgewecke]

@nmushegian What would make you most comfortable here? No requests by default?

[nmushegian]

I think that's reasonable. FWIW in my experience the only other entities that ships packages that make spurious requests, are Facebook and Google.

One possible usage

• print a helpful one liner like no price provider configured, type <relevant help command> for info at start of report
• not configured or similar as default value in the table
• you can provide the url as an env var or part of the hardhat config

One side benefit of encouraging an explicit PRICE_RPC_URL is eventually we can swap it out with some nice eth AMM backed whatever. Like how we can swap ETH_RPC_API now that theoretical concerns about Infura are becoming real.

[cgewecke]

Fixed in eth-gas-reporter 0.2.26

rip @nmushegian