cgewecke
cgewecke
@vongohren Yes I think you're right - it might be good idea even if that pattern is really rare. Thanks for raising this.
Ah ok! I'll ping you.
@cruzdanilo It is a dev dependency here... https://github.com/cgewecke/eth-gas-reporter/blob/13c3e19487eb38cc0c92ab99aafc48f5626a9623/package.json#L53-L54 Do you think it should be a "real" dependency? The engineer who writes codechecks suggested the current format while [reviewing the PR...
Completely decoupling the check was another suggested option... https://github.com/cgewecke/eth-gas-reporter/pull/131#issuecomment-502873774
> decoupling would be the best Tbh I didn't do it this way because it's more convenient to maintain/develop it in the same repo. The user would also have to...
Ah I see! Ok that makes sense.
This has been added in `0.2.7`, just need to verify it works...
Needs #171 for Aragon installation / testing...
Yes, that looks right to me. As a practical matter this tool is usually run with HardhatEVM or ganache-cli (both ethereumjs-vm based) It would nice to know if gasUsedL2 on...
Cross-linking relevant issue at hardhat-gas-reporter https://github.com/cgewecke/hardhat-gas-reporter/issues/78 Will think a little bit about how this should be done....if we take the simplest approach and don't worry about representing the different layer...