cgettys-microsoft

Results 22 comments of cgettys-microsoft

I have no idea, I've contributed some but am not all-knowing :). Have you tried running the test in question under Miri? the downcasting I believe involves some unsafe code...

Wouldn't precision support exactly this, while being technically correct? "For non-numeric types, this can be considered a **“maximum width”**. If the resulting string is longer than this width, then it...

Neither did I, fwiw 😄. I just went "there has to be _some_ way that that's supported, surely" and had better luck stumbling onto the right method documentation apparently

To be clear - this is just a musing from another fellow user of the library, not something you necessarily need to address. But if we were being hyper-pedantic, this...

Perhaps another way to solve for this scenario would be to have: ```rust impl Report { pub fn with_handler(self, new_handler: Box -> Self { let inner = unsafe { self.inner.boxed()...

> > But that .clone() might get expensive. > > I considered that too, but the current struct doesn't look too bad. It's also already being cloned in multiple places...

> As a general thought on performance: I don't consider extreme performance to be super important for the graphical renderer. It's kind of already assumed this is a "one and...

> Ok, I think this is blocked on #451 #451 perhaps isn't the optimal solution (I couldn't get any combination of --locked and package versions to play nice without raising...

Just in case you missed it, #451 merged

To be clear, my comments are just my opinion - I'm neither the author nor am I a maintainer of this library, I'm just a person who has submitted a...