cgeo.github.io icon indicating copy to clipboard operation
cgeo.github.io copied to clipboard
verified publisher icon cgeo

provide language selection as URL parameter

Open Bananeweizen opened this issue 8 years ago • 7 comments

We should have the possibility to provide the wanted language for the FAQ via URL parameter. If that were available, we could invoke the FAQ from inside cgeo using the language of the cgeo app. That way a German user would immediately land on the German version of the FAQ.

Bananeweizen avatar Sep 06 '17 17:09 Bananeweizen

If he has set up his browser / system language correctly it should be opened in the user locale by default. On the other hand this is easy to implement.

SammysHP avatar Sep 06 '17 19:09 SammysHP

@SammysHP I've already implemented this locally.

/faq?lang=de

I'll make a pull request together with my fix for #153.

niklashigi avatar Sep 07 '17 09:09 niklashigi

At least on my phone just going from the app (with German localization) to the FAQ does not lead to German text. I'm not thinking I have anything set to English on my real device.

Bananeweizen avatar Sep 07 '17 15:09 Bananeweizen

Works fine here.

SammysHP avatar Sep 07 '17 17:09 SammysHP

What link within the app are you trying @Bananeweizen @SammysHP ?

Lineflyer avatar Sep 07 '17 17:09 Lineflyer

@Lineflyer In "about c:geo" faq.cgeo.org.

SammysHP avatar Sep 07 '17 18:09 SammysHP

Ah, you are right. I get the German version, but the first paragraph of the FAQ itself is not translated, only the questions underneath. That made me think I had the English version.

Bananeweizen avatar Sep 08 '17 06:09 Bananeweizen