WhereYouGo icon indicating copy to clipboard operation
WhereYouGo copied to clipboard
verified publisher icon cgeo

fix #357 Locus integration not working

Open sk-juroot opened this issue 3 years ago • 2 comments

fixes #357

Description

  • bump Locus API library on Gradle from 0.2.7 to 0.9.45
  • removed Location initializer with string (no longer supported)
  • changed LAPI dependencies in files to newer version + required refactor of corresponding code
  • changed Location inits with only TAG string resource (obsolete)
  • changed Location.Accuracy (removed support) to horizontal accuracy
  • removed dependency on locus api when loading cartridges (never fully implemented)

Related issues

  • #357

Additional context

  • this PR is in Do not merge / WIP state until fully tested
  • tried this fix with only one cartridge (with Locus 4 Gold @ Android 11), will do more testing of this change when outside
  • more tests with other Locus versions recommended

sk-juroot avatar Jan 09 '22 10:01 sk-juroot

  • changed Location.Accuracy (removed support) to horizontal accuracy

I am fine if we stay in this way. Maybe it is better to implement an own self calculated Location.Accuracy.

bekuno avatar Jan 09 '22 14:01 bekuno

  • changed Location.Accuracy (removed support) to horizontal accuracy

I am fine if we stay in this way. Maybe it is better to implement an own self calculated Location.Accuracy.

I have to correct me. My mistake was that I confused vertical = height with North-South direction. So there is no need for a setAccuracyVer .

bekuno avatar Jan 10 '22 08:01 bekuno

@sk-juroot Are you interested to finish your work? If you can do it the next days, then we should wait for it before creating the next release.

bekuno avatar Feb 22 '23 08:02 bekuno

@sk-juroot Are you interested to finish your work? If you can do it the next days, then we should wait for it before creating the next release.

Too late for that, release got published already because of urgent adaption to website changes, but creating a second release in a short time would not be a problem.

moving-bits avatar Feb 22 '23 21:02 moving-bits

Hi, what's the status, please? I'm concerned about a broken integration with Locus Classic. If you're interested, I've solved the update locus api lib in ref_357_upgrade_locusapi. It is also possible to create a PR if there is interest. Cheers.

Dratenik avatar Feb 24 '23 20:02 Dratenik

Hi, what's the status, please? I'm concerned about a broken integration with Locus Classic. If you're interested, I've solved the update locus api lib in ref_357_upgrade_locusapi. It is also possible to create a PR if there is interest. Cheers.

@Dratenik We are very grateful for any help. I have checked your branch. The change looks very good. Please create a PR.

bekuno avatar Feb 24 '23 22:02 bekuno

@sk-juroot Many thanks for your initial work. Closing here, this PR is now replaced by #426.

bekuno avatar Feb 26 '23 17:02 bekuno