WhereYouGo icon indicating copy to clipboard operation
WhereYouGo copied to clipboard

Bugfix release on legacy branch

Open bekuno opened this issue 4 years ago • 10 comments

Do we want do further thinks on this branch before release it as version 0.9.4?

My suggestions are to adopt

  • [x] PR #25 Updated main menu links
  • [x] PR #32 Update about pages
  • [x] PR #60 Changelog

done:

  • [x] PR #157 - adopt PR #5 https for cartridge download

bekuno avatar Apr 21 '20 17:04 bekuno

AFAICS the changes of #25 are already on legacy

Lineflyer avatar Jun 15 '20 21:06 Lineflyer

Update: This is all already done on legacy, isn't it?

Lineflyer avatar Jun 15 '20 21:06 Lineflyer

Yes, with PR #183 all points above are implemented, and additional points. And yes, on legacy.

bekuno avatar Jun 16 '20 08:06 bekuno

@bekuno You wrote in some other issue, that we could release the legacy version (from code status).

What we need (and I cannot provide or don't know):

  • Build an APK with appropriate versioncode / versionname I suggest to use something like "yyyy.mm.dd-legacy" like we do for c:geo in order to be consistently able to release from Google Play also later on
  • Set minsdk/maxsdk accordingly to seperate legacy from the production build

Alternatively we could just build a version from legacy and make it available to download somewhere outside of Google Play.

I can do the Google Play handling once someone manages to prepare e.g. the CI-environment to make a proper build from legacy branch (same handling as in c:geo) or at least provides a matching APK once. Sorry, but I am technically and timely not able to assist here besides that.

Lineflyer avatar Jun 19 '20 09:06 Lineflyer

I created a new job on our CI: https://ci.cgeo.org/view/WhereYouGo/job/WhereYouGo%20(legacy%20release)/

As the automatic versioning has only been created on master/release we just set the versionCode and versionName manually in build.gradle. I have set it to versionName=2020.06.25-legacy with versionCode=20200625 for now and successfully built an APK.

Its basically working (incl. download of cartridges) I will additionally test it on a SDK=15 device. Afterwards I need to check whether Google Play will accept this update and targets it to minSDK=maxSDK=15.

Will report back.

Lineflyer avatar Jun 25 '20 19:06 Lineflyer

Everything seems as expected now, also Google Play pre-check shows it will accept the version and distribute to SDK=15 only. I asked @kurly1 in #156 to load and test the version on a Garmin Monterra (=SDK15).

Lineflyer avatar Jun 25 '20 20:06 Lineflyer

@Lineflyer Thanks for preparing and releasing :-)

bekuno avatar Jun 26 '20 06:06 bekuno

As discussed in #156 I will wait if maybe a solution for enabling in-app download is possible

Lineflyer avatar Jul 02 '20 19:07 Lineflyer

@Lineflyer The legacy branch thas targetSdkVersion 28. How about make a new legacy release with the current changes?

bekuno avatar Oct 29 '20 09:10 bekuno

mmh...the legacy version was never published as the feedback in #156 was negative when it comes to downloading cartridges. I guess its to late for a legacy now.

If we at some point of time have a working solution for Monterra we can offer the APK for direct download.

Lineflyer avatar Oct 29 '20 21:10 Lineflyer