angular-toggle-switch icon indicating copy to clipboard operation
angular-toggle-switch copied to clipboard

Allow empty labels, move state CSS class to outer div.

Open adamdicarlo opened this issue 10 years ago • 6 comments

@cgarvis how do these changes look?

  • Allow empty labels: See the new tests, which fail on the existing code
  • Template change: This allows more styling flexibility. Specifically, I did this so I could color the main outline red or green depending on whether it's off or on. It's a lot easier to put the border on the outer element.
  • Updated the build (btw I think it was already out of date).

adamdicarlo avatar Jan 06 '15 00:01 adamdicarlo

I'd suggest bumping major version if you merge this, due to the CSS change.

adamdicarlo avatar Jan 06 '15 00:01 adamdicarlo

Ah, did you want me to remove the "Update build" commit from this PR?

adamdicarlo avatar Jan 06 '15 22:01 adamdicarlo

Yeah don't have the build commit. I do that on a release on github. That way the built js is what is stable.

cgarvis avatar Jan 07 '15 01:01 cgarvis

(Will re-push without the 'Update build' commit tomorrow)

adamdicarlo avatar Jan 07 '15 02:01 adamdicarlo

Re-pushed without the Update build commit.

adamdicarlo avatar Jan 07 '15 17:01 adamdicarlo

Is this merge worthy? Anything I can do to clean it up?

adamdicarlo avatar Jan 28 '15 23:01 adamdicarlo