cfv icon indicating copy to clipboard operation
cfv copied to clipboard

Fix tests for Python 3.12: remove "imp", fixes #21, #44

Open sbraz opened this issue 1 year ago • 3 comments

Hi, This patch is required for tests to pass with Python 3.12, along with 5259bcbe3434c6974f7a65cc435dd0b4cfc3f864.

The "imp" module was removed in Python 3.12. The replacement functions were added in Python 3.5, see https://docs.python.org/3/library/importlib.html#importlib.util.spec_from_file_location https://docs.python.org/3/library/importlib.html#importlib.util.module_from_spec

sbraz avatar May 12 '24 14:05 sbraz

Thanks for your pull request! I will have a look at it, after fixing the CI pipeline.

lxp avatar May 15 '24 19:05 lxp

Your changes look good, although I have not tested it yet. The CI pipeline is fixed, but it is not used in your PR yet. Could you please rebase your changes?

lxp avatar May 16 '24 02:05 lxp

@lxp done, sorry about the mess, I got confused because of the unusual target branch name :D

sbraz avatar May 16 '24 22:05 sbraz

Thank you!

lxp avatar May 18 '24 09:05 lxp