dio icon indicating copy to clipboard operation
dio copied to clipboard

Add a dio_test project and move request integration test

Open kuhnroyal opened this issue 1 year ago • 3 comments

This was supposed to be just an attempt but while moving the integration test, I found a bug since one of the tests failed for the Http2Adapter. So I think this is a good approach, I will move more tests in future PRs.

  • run tests for all adapters
  • fix redirect bug for Http2Adapter

New Pull Request Checklist

  • [x] I have read the Documentation
  • [x] I have searched for a similar pull request in the project and found none
  • [x] I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • [x] I have added the required tests to prove the fix/feature I'm adding
  • [x] I have updated the documentation (if necessary)
  • [x] I have run the tests without failures
  • [x] I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

kuhnroyal avatar Dec 22 '23 14:12 kuhnroyal

@AlexV525 What do you think about this approach? There is also a bugfix for redirects in here.

kuhnroyal avatar Jan 10 '24 21:01 kuhnroyal

There is also a bugfix for redirects in here.

Can we extract the fix to another request first?

AlexV525 avatar Jan 16 '24 07:01 AlexV525

There is also a bugfix for redirects in here.

Can we extract the fix to another request first?

Done. See #2101

kuhnroyal avatar Jan 21 '24 20:01 kuhnroyal

I moved some tests in to the test package but I think we should move the rest in separate PRs. So I think this is good to go if we want to take that route.

kuhnroyal avatar Mar 04 '24 22:03 kuhnroyal