dio icon indicating copy to clipboard operation
dio copied to clipboard

fix(develop): HTTP/2 error: Stream error #486

Open xrr2016 opened this issue 3 years ago • 4 comments

New Pull Request Checklist

  • [x] I have read the Documentation
  • [x] I have searched for a similar pull request in the project and found none
  • [x] I have updated this branch with the latest develop to avoid conflicts (via merge from master or rebase)
  • [x] I have added the required tests to prove the fix/feature I am adding
  • [x] I have updated the documentation (if necessary)
  • [x] I have run the tests and they pass

This merge request fixes / refers to the following issues: ...

Pull Request Description

Fix DioError [DioErrorType.DEFAULT]: HTTP/2 error: Stream error: Stream was terminated by peer (errorCode: 1)

Ref

https://github.com/dart-lang/http2/issues/49

https://github.com/flutterchina/dio/issues/486

xrr2016 avatar Mar 04 '22 06:03 xrr2016

@ueman @kuhnroyal can you please review this and merge it?

itsbalamurali avatar Apr 10 '22 12:04 itsbalamurali

@xrr2016 Hi, please check the issue I fired before. The real issue that should be fixed is here. It is not the issue about http2, but Options.

Nobler avatar May 25 '22 09:05 Nobler

By the way, some unit tests should be added for sure.

Nobler avatar May 25 '22 09:05 Nobler

This PR does not resolve the issue from what I can see.

SahajRana avatar Sep 06 '22 21:09 SahajRana

Hi everyone! We've made our hardfork repo public and published a new version of dio, named diox. The new package contains the PR of the fix. Please refer to https://pub.dev/packages/diox/versions/5.0.0-dev.1 to use the fork. You can also see why we're working for a hardfork at https://github.com/cfug/diox/issues/29 and https://github.com/flutterchina/dio/issues/1607.

AlexV525 avatar Dec 18 '22 15:12 AlexV525