dio
dio copied to clipboard
cfug
Http2 proxy
New Pull Request Checklist
- [X] I have read the Documentation
- [X] I have searched for a similar pull request in the project and found none
- [X] I have updated this branch with the latest
developto avoid conflicts (via merge from master or rebase) - [ ] I have added the required tests to prove the fix/feature I am adding
- [X] I have updated the documentation (if necessary)
- [X] I have run the tests and they pass
This merge request fixes / refers to the following issues: #1259 #905
Pull Request Description
Added proxy tunnel to http2 adaptor
@Overman775 You should really write tests covering these changes. Otherwise, somebody could break this functionality without noticing.
Also please don't tick the checkbox which says that you've written tests, if you don't have written tests.
I'm also not a maintainer of this library, but I believe the maintainer would agree in most cases.
Overall it looks already promising and it would be a great addition to the library 👍
@Overman775 You should really write tests covering these changes. Otherwise, somebody could break this functionality without noticing.
Also please don't tick the checkbox which says that you've written tests, if you don't have written tests.
I'm also not a maintainer of this library, but I believe the maintainer would agree in most cases.
Overall it looks already promising and it would be a great addition to the library 👍
There were no tests initially, it is difficult to write tests for Socket. This code does not contain breakin changes
@Overman775 Are you still able to work on this?
Thought it would never happen ) I will update the PR soon
Thought it would never happen ) I will update the PR soon
For now you can consider to purpose the PR to diox since dio is not going to maintain anymore.
Or you can hold on for a couple of days, we have some incoming changes that need to announce. :)
@Overman775 Are you still able to work on this?
Thought it would never happen ) I will update the PR soon
Or you can hold on for a couple of days, we have some incoming changes that need to announce. :)
Now dio will continue to be maintained by the CFUG organization, diox has been migrated to dio, you can continue your work and join in dio.
Test added. the test requires a proxy server, do you have any ideas how to check? The use of free proxies is extremely unstable I have not seen a local http proxy server on dart
Hey, guys I wanted to get started supporting and contributing to this package, I need someone to onboard me. You can DM me directly on [email protected]
Test added. the test requires a proxy server, do you have any ideas how to check?
Do we have a minimum requirement for setting up an HTTP/2 proxy?
Do we have a minimum requirement for setting up an HTTP/2 proxy?
simple http\https proxy with normal latency theoretically, we can run a local proxy server on github actions
simple http\https proxy with normal latency theoretically, we can run a local proxy server on github actions
Sounds good. You can follow how the server is being setup in the existing tests to write startup the proxy in the proxy tests.
simple http\https proxy with normal latency theoretically, we can run a local proxy server on github actions
Sounds good. You can follow how the server is being setup in the existing tests to write startup the proxy in the proxy tests.
all done, added proxy server on test flow. Please approve new test actions https://github.com/cfug/dio/actions/runs/4317864902
@AlexV525 When will the request be approved? Is there anything else that needs to be finalized?
Ah so you indeed didn't notice the previous comment as I imagine. See https://github.com/cfug/dio/pull/1386#discussion_r1128730582
Ah so you indeed didn't notice the previous comment as I imagine. See #1386 (comment)
@AlexV525 done )